Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Parametric tests for DOGSTATSD Configurations #3649

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Adding Parametric tests for DOGSTATSD Configurations #3649

merged 7 commits into from
Dec 13, 2024

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Dec 9, 2024 •
edited by jira bot
Loading

Motivation

Adding tests for tracing configs to make sure implementation across all languages are consistent, based upon the following RFC.

Changes

  • Add test cases for when DD_DOGSTATSD_HOST and DD_DOGSTATSD_PORT are specified, as well as when neither are included.
  • Updated test_library tracing/config endpoint helper to include these fields for parametric apps
  • Updated Java, Python, and NodeJS tracing/config endpoint in parametric apps to support the behavior
  • Updated all manifest files in order to reflect the current expected behavior of the tests

APMAPI-948
APMAPI-949

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mhlidd mhlidd requested a review from khanayan123 December 9, 2024 20:42
@mhlidd mhlidd marked this pull request as ready for review December 9, 2024 20:46
@mhlidd mhlidd requested review from a team and mabdinur as code owners December 9, 2024 20:46
@mhlidd mhlidd requested review from sabrenner, manuel-alvarez-alvarez, Mariovido and pablomartinezbernardo and removed request for a team December 9, 2024 20:46
@mhlidd mhlidd mentioned this pull request Dec 10, 2024
Merged
6 tasks
@mhlidd
Copy link
Contributor Author

mhlidd commented Dec 12, 2024

Failing DOTNET parametric tests are irrelevant

@mhlidd mhlidd merged commit 2a8642d into main Dec 13, 2024
433 of 435 checks passed
@mhlidd mhlidd deleted the mhlidd/dd_dogstatsd branch December 13, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanayan123 khanayan123 khanayan123 approved these changes

@cbeauchesne cbeauchesne cbeauchesne approved these changes

@mabdinur mabdinur Awaiting requested review from mabdinur mabdinur is a code owner

@sabrenner sabrenner Awaiting requested review from sabrenner sabrenner is a code owner automatically assigned from DataDog/apm-python

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/asm-java

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/asm-java

@pablomartinezbernardo pablomartinezbernardo Awaiting requested review from pablomartinezbernardo pablomartinezbernardo is a code owner automatically assigned from DataDog/dd-trace-cpp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhlidd @cbeauchesne @khanayan123 @bm1549